- This topic has 13 replies, 3 voices, and was last updated 4 weeks ago by
.
-
-
Hello,
We have a problem with the child theme import functionality, that I’m sure everyone will be able to replicate easily if their child theme is using Presets. None of the child theme presets are being imported correctly on Divi version 4.19.3 and 4.19.4. The import process works correctly on Divi 4.19.2.
I hope you’ll be able to investigate this further, Terry @mizagorn
-
-
@divilover and @michelle, sorry for the delay and thanks for letting me know.
Can you explain a bit more about what types (or all?) presets are not importing? An example would be extremely helpful so I know where to look in the code. Screenshots, errors logs, anything at all. I can’t replicate all setups. 🙁
Also to confirm, any version of Divi *above* 4.19.2 is having this issue? I will scan the changelogs to see what updates were made in relevant places.
-
Hi Terry,
I appreciate your help.
So the problem is with all global presets. Very easy to replicate. If you add a new preset or change the default preset of any module inside a child theme – none of these design settings will import. In Divi 4.9.13, ET moved presets to a separate setting. It’s in the changelog under “Improved Presets storage and performance.” and the change is visible in the includes/builder/feature/global-presets/Settings.php file in Divi. So yes, any version of Divi above 4.19.2 is having this issue.
I managed to get this to work by including the et_divi_builder_global_presets_ng WP Option in the EDI settings. That imports all prestes correctly, but the problem is that it overwrites any of the existing presets a website would have before the demo import, so it isn’t an ideal solution.
Hopefully, this helps. Thank you again for taking the time to look into it.
-
@divilover thanks so much for the amazing feedback. It has been a tremendous help.
I have been looking into the options slugs, which look like include builder_global_presets, builder_global_presets_ng and builder_global_presets_temp.
As I’m sure you’re aware, these are all used for backwards compatibility and current usage.
There is code within the plugin that is specific to Divi. My idea is to create an option (for Divi) titled something like “Merge or Replace Divi Global Settings”. This specifies if the global settings from the import will either replace or add to (merge) the already existing global settings.
Does this seem like a good idea to you? Also @michelle
-
Thank you, Terry, for taking the time to look into it for us.
If the end user saw a checkbox to “Include Global Presets,” it would be perfect. If we only merged their current presets with the new ones from the demo – that would be a good enough solution, and offering a choice for replacing presets wouldn’t be necessary, as we don’t do it for other import “parts.”
I would vote for calling it what it is: “Presets” instead of “Settings”. “Global settings” could be a bit confusing, as other “global” options are included in our child themes in various places.
This approach would match other import settings very well (e.g., with “Include Posts,” we are only adding new posts without touching what’s already on the site, and we don’t have the option for replacing existing posts).
-
-
-
-
-
@divilover Ania okay that’s odd. I only tested with one theme, I’ll have to try the others.
@mizagorn Terry I agree with Ania, we need it called preset and merging is fine for me too.Question? Will we need to repackage all themes with this fix? Cause that’s no fun 😉
-
-
-
@divilover and @michelle
Apologies for the delay on getting your users some information as to what’s going on. If you have alternatives after waiting so long, that’s good! You should go ahead. I’m currently going through some negative stuff. 😉
Good, news, though…. I have the framework in place. What’s challenging is that Divi uses a single entry in the options table to set global values.
In other words, one entry in the “wp_options” table defines all global options!
I need to decipher what’s going on with that, how to parse it out, and then make sure merging or replacing is something that works.
-
Hi Terry and thanks for the update.
I don’t currently have an alternative and I am getting regular support requests on this.
@divilover are you able to explain how you managed to get this to work, even with it overwriting existing presets please? -
Thank you, Terry, for taking the time to work on this. I appreciate it.
I have a temporary solution, but it is not 100% satisfactory.
@michelle I included the et_divi_builder_global_presets_ng WP Option in the EDI settings before exporting. Please see this screenshot: https://imgur.com/QWEA6SMThat replaces all global settings upon demo import, but it only works with Divi 4.19.3 and up. It will not import any presets when used with an older Divi version.
-
-
-
- You must be logged in to reply to this topic.
Fullscreen Vimeo background?
